Re: [PATCH net-next 2/4] net/smc: remove the fallback in __smc_connect
From: Wenjia Zhang <wenjia@linux.ibm.com>
Date: 2024-08-01 07:24:13
Also in:
linux-s390
On 01.08.24 03:22, shaozhengchao wrote:
quoted hunk ↗ jump to hunk
Hi Wenjia Zhang: Looks like the logic you're saying is okay. Do I need another patch to perfect it? As below:diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 73a875573e7a..b23d15506afc 100644 --- a/net/smc/af_smc.c +++ b/net/smc/af_smc.c@@ -1523,7 +1523,7 @@ static int __smc_connect(struct smc_sock *smc) ini->smcd_version &= ~SMC_V1; ini->smcr_version = 0; ini->smc_type_v1 = SMC_TYPE_N; - if (!ini->smcd_version) { + if (!smc_ism_is_v2_capable()) { rc = SMC_CLC_DECL_GETVLANERR; goto fallback; }Thank you Zhengchao Shao
Hi Zhengchao, I see your patches series were already applied yesterday. So It's okay to let it be now. As I said, your changes are not wrong, just not clean enough IMO. Anyway, thanks for your contribution to our code! Thanks, Wenjia