On Wed, 31 Jul 2024 14:30:23 +0200
Alice Ryhl [off-list ref] wrote:

quoted

quoted

+//! Commonly used sizes.
+//!
+//! C headers: [`include/linux/sizes.h`](srctree/include/linux/sizes.h).
+
+/// 0x00000400
+pub const SZ_1K: usize = bindings::SZ_1K as usize;

1K is 1K, independent of it being C 1K or Rust 1K. In this case, does
it makes sense to actually use the C header? I don't know? But the
Rust people seems to think this is O.K.

Shrug. I don't think it really matters.

If using the C header required adding constants in
rust/bindings/bindings_helper.h to actually make the constants usable
from Rust, then I would say we should just set the constants from the
Rust side. But in this case using the C header just works so I don't
think it's an issue.

Either is fine by me. I'll keep the current version if nobody has
strong preference.

Thanks for the quick review!