Re: [PATCH bpf 1/6] selftest/bpf: Support more socket types in create_pair()
From: Michal Luczaj <hidden>
Date: 2024-07-31 10:05:59
Also in:
bpf, linux-kselftest
Possibly related (same subject, not in this thread)
- 2024-07-26 · Re: [PATCH bpf 1/6] selftest/bpf: Support more socket types in create_pair() · Michal Luczaj <hidden>
- 2024-07-26 · Re: [PATCH bpf 1/6] selftest/bpf: Support more socket types in create_pair() · Jakub Sitnicki <jakub@cloudflare.com>
- 2024-07-24 · [PATCH bpf 1/6] selftest/bpf: Support more socket types in create_pair() · Michal Luczaj <hidden>
On 7/30/24 19:13, Jakub Sitnicki wrote:
On Fri, Jul 26, 2024 at 10:29 PM +02, Michal Luczaj wrote:quoted
On 7/26/24 19:23, Jakub Sitnicki wrote:quoted
I was going to suggest that a single return path for success is better than two (diff below), but I see that this is what you ended up with after patch 6. So I think we can leave it as is. [...]And speaking of which, would you rather have patch 1 and 6 squashed?Don't have a straight answer, sorry . Would have to see if the diff is clear enough after squashing it. Use your best judgement. It's certainly fine with me to review the steps that were taken to massage the code.
That's what I've assumed, thanks. So here's the bpf-next based respin: https://lore.kernel.org/bpf/20240731-selftest-sockmap-fixes-v2-0-08a0c73abed2@rbox.co (local)