Thread (2 messages) 2 messages, 2 authors, 2024-07-30

Re: [PATCH bpf-next] xsk: Try to make xdp_umem_reg extension a bit more future-proof

From: patchwork-bot+netdevbpf@kernel.org
Date: 2024-07-30 22:20:31
Also in: bpf

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau [off-list ref]:

On Fri, 26 Jul 2024 15:20:48 -0700 you wrote:
We recently found out that extending xsk_umem_reg might be a bit
complicated due to not enforcing padding to be zero [0]. Add
a couple of things to make it less error-prone:
1. Remove xdp_umem_reg_v2 since its sizeof is the same as xdp_umem_reg
2. Add BUILD_BUG_ON that checks that the size of xdp_umem_reg_v1 is less
   than xdp_umem_reg; presumably, when we get to v2, there is gonna
   be a similar line to enforce that sizeof(v2) > sizeof(v1)
3. Add BUILD_BUG_ON to make sure the last field plus its size matches
   the overall struct size. The intent is to demonstrate that we don't
   have any lingering padding.

[...]
Here is the summary with links:
  - [bpf-next] xsk: Try to make xdp_umem_reg extension a bit more future-proof
    https://git.kernel.org/bpf/bpf-next/c/32654bbd6313

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help