Thread (8 messages) read the whole thread 8 messages, 6 authors, 2024-07-29

Re: [PATCH bpf] selftests/bpf: Filter out _GNU_SOURCE when compiling test_cpp

From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-07-27 01:10:22
Also in: bpf

On Fri, 26 Jul 2024 17:45:06 -0700 Andrii Nakryiko wrote:
or we could

#ifndef _GNU_SOURCE
#define _GNU_SOURCE
#endif

(though we have 61 places with that...) so as to not have to update
every target in Makefile.
AFAIU we have -D_GNU_SOURCE= twice _in the command line args_ :(
One is from the Makefile which now always adds it to CFLAGS,
the other is "built-in" in g++ for some weird reason.

FWIW I have added this patch to the netdev "hack queue" so no
preference any more where the patch lands :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help