Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference... | netdev

[PATCH bpf-next v2 0/9] Add BPF LSM return value range check, BPF part · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
[PATCH bpf-next v2 1/9] bpf, lsm: Add disabled BPF LSM hook list · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
[PATCH bpf-next v2 3/9] bpf: Prevent tail call between progs attached to different hooks · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
[PATCH bpf-next v2 7/9] selftests/bpf: Add return value checks for failed tests · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
[PATCH bpf-next v2 2/9] bpf, lsm: Add check for BPF LSM return value · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
[PATCH bpf-next v2 4/9] bpf: Fix compare error in function retval_range_within · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
[PATCH bpf-next v2 6/9] selftests/bpf: Avoid load failure for token_lsm.c · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
[PATCH bpf-next v2 9/9] selftests/bpf: Add verifier tests for bpf lsm · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
[PATCH bpf-next v2 8/9] selftests/bpf: Add test for lsm tail call · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
[PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND · Xu Kuohai <xukuohai@huaweicloud.com> · 2024-07-19
Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND · Eduard Zingerman <eddyz87@gmail.com> · 2024-07-22
Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND · Shung-Hsi Yu <hidden> · 2024-07-22
Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND · Eduard Zingerman <eddyz87@gmail.com> · 2024-07-22
Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND · Alexei Starovoitov <hidden> · 2024-07-23
Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND · Shung-Hsi Yu <hidden> · 2024-07-23
Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND · Shung-Hsi Yu <hidden> · 2024-07-23
Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND · Alexei Starovoitov <hidden> · 2024-07-24
Re: [PATCH bpf-next v2 0/9] Add BPF LSM return value range check, BPF part · patchwork-bot+netdevbpf@kernel.org · 2024-07-23

Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND

From: Eduard Zingerman <eddyz87@gmail.com>
Date: 2024-07-22 18:48:01
Also in: bpf, linux-security-module

On Mon, 2024-07-22 at 20:57 +0800, Shung-Hsi Yu wrote:

[...]

quoted

As a nitpick, I think that it would be good to have some shortened
version of the derivation in the comments alongside the code.

Agree it would. Will try to add a 2-4 sentence explanation.

quoted

(Maybe with a link to the mailing list).

Adding a link to the mailing list seems out of the usual for comment in
verifier.c though, and it would be quite long. That said, it would be
nice to hint that there exists a more verbose version of the
explanation.

Maybe an explicit "see commit for the full detail" at the end of
the added comment?

Tbh, I find bounds deduction code extremely confusing.
Imho, having lengthy comments there is a good thing.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help