Thread (4 messages) 4 messages, 4 authors, 2024-08-02

Re: [PATCH net v1] net: wan: fsl_qmc_hdlc: Discard received CRC

From: Simon Horman <horms@kernel.org>
Date: 2024-07-31 08:44:48
Also in: linuxppc-dev, lkml, stable

On Tue, Jul 30, 2024 at 08:31:33AM +0200, Herve Codina wrote:
Received frame from QMC contains the CRC.
Upper layers don't need this CRC and tcpdump mentioned trailing junk
data due to this CRC presence.

As some other HDLC driver, simply discard this CRC.
It might be nice to specifically site an example.
But yes, I see this pattern in hdlc_rx_done().
Fixes: d0f2258e79fd ("net: wan: Add support for QMC HDLC")
Cc: stable@vger.kernel.org
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
 drivers/net/wan/fsl_qmc_hdlc.c | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)
The above notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help