Thread (13 messages) 13 messages, 7 authors, 2024-08-01

Re: [PATCH net-next] net: skbuff: Skip early return in skb_unref when debugging

From: Paolo Abeni <pabeni@redhat.com>
Date: 2024-07-30 11:16:04
Also in: lkml


On 7/30/24 12:50, Florian Westphal wrote:
Paolo Abeni [off-list ref] wrote:
quoted
quoted
   	else if (likely(!refcount_dec_and_test(&skb->users)))
   		return false;
I think one assumption behind CONFIG_DEBUG_NET is that enabling such config
should not have any measurable impact on performances.
If thats the case why does it exist at all?

I was under impression that entire reason for CONFIG_DEBUG_NET was
to enable more checks for fuzzers and the like, i.e. NOT for production
kernels.
I feel like I already had this discussion and I forgot the outcome, if 
so I'm sorry. To me the "but is safe to select." part in the knob 
description means this could be enabled in production, and AFAICS the 
CONFIG_DEBUG_NET-enabled code so far respects that assumption.

Thanks,

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help