Thread (32 messages) 32 messages, 3 authors, 2024-07-11

Re: [PATCH net-next v16 05/13] page_pool: devmem support

From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-07-11 01:23:24
Also in: bpf, dri-devel, linux-alpha, linux-arch, linux-doc, linux-kselftest, linux-media, linux-mips, linux-mm, linux-trace-kernel, lkml, sparclinux

On Wed, 10 Jul 2024 16:42:04 -0700 Mina Almasry wrote:
quoted
quoted
+static inline void netmem_set_pp(netmem_ref netmem, struct page_pool *pool)
+{
+     __netmem_clear_lsb(netmem)->pp = pool;
+}  
Why is all this stuff in the main header? It's really low level.
Please put helpers which are only used by the core in a header
under net/core/, like net/core/dev.h  
Sorry none of those are only used by net/core/*. Pretty much all of
these are used by include/net/page_pool/helpers.h, and some have
callers in net/core/devmem.c or net/core/skbuff.c

Would you like me to move these pp specific looking ones to
include/net/page_pool/netmem.h or something similar?
That's because some things already in helpers have no real business
being there either. Why is page_pool_set_pp_info() in helpers.h?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help