Thread (21 messages) 21 messages, 5 authors, 2024-07-25

Re: [PATCH] net: linearizing skb when downgrade gso_size

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2024-07-10 23:07:25
Also in: bpf, lkml

On Tue, Jul 09, 2024 at 05:29:59PM -0400, Willem de Bruijn wrote:
This is an unfortunate feature, but already exists.

It decreases gso_size to account for tunnel headers.
Growing the tunnel header is totally fine.  But you should not
decrease gso_size because of that.  Instead the correct course
of action is to drop the packet and generate an ICMP if it no
longer fits the MTU.

A router that resegments a TCP packet at the TCP-level (not IP)
is brain-dead.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help