Re: [PATCH net-next v10 12/15] mm: page_frag: move 'struct page_frag_cache' to sched.h
From: Alexander Duyck <hidden>
Date: 2024-07-09 14:57:05
Also in:
linux-mm, lkml
From: Alexander Duyck <hidden>
Date: 2024-07-09 14:57:05
Also in:
linux-mm, lkml
On Tue, Jul 9, 2024 at 6:31 AM Yunsheng Lin [off-list ref] wrote:
As the 'struct page_frag_cache' is going to replace the 'struct page_frag' in sched.h, including page_frag_cache.h in sched.h has a compiler error caused by interdependence between mm_types.h and mm.h for asm-offsets.c, see [1]. Avoid the above compiler error by moving the 'struct page_frag_cache' to sched.h as suggested by Alexander, see [2].
Both the title and this description are misleading. You are moving it to mm_types_task.h not sched.h. Also I am pretty sure you could just fold this into your second patch where you moved the code originally with just a tweak to the description explaining the build dependency issue. No point in moving the same structure twice within the same patch set.