Re: [PATCH 29/47] dt-bindings: net: qcom,ethqos: add description for qcs9100

On 7/5/2024 12:03 AM, Andrew Lunn wrote:

On Thu, Jul 04, 2024 at 09:13:59AM +0800, Tengfei Fan wrote:

quoted

On 7/3/2024 11:09 PM, Andrew Halaney wrote:

quoted

On Wed, Jul 03, 2024 at 10:58:32AM GMT, Tengfei Fan wrote:

quoted

Add the compatible for the MAC controller on qcs9100 platforms. This MAC
works with a single interrupt so add minItems to the interrupts property.
The fourth clock's name is different here so change it. Enable relevant
PHY properties. Add the relevant compatibles to the binding document for
snps,dwmac as well.

This description doesn't match what was done in this patch, its what
Bart did when he made changes to add the sa8775 changes. Please consider
using a blurb indicating that this is the same SoC as sa8775p, just with
different firmware strategies or something along those lines?

I will update this commit message as you suggested.

Hi Andrew, Tengfei

Please trim emails when replying to just the needed context.

Thanks
	Andrew

Thank you for pointing out this. In the future, I will pay attention to 
trimming emails when I reply.

-- 
Thx and BRs,
Tengfei Fan