On Mon, Jul 01, 2024 at 03:17:58PM +0200, Maxime Chevallier wrote:
quoted hunk ↗ jump to hunk
The ETH_SS_PHY_STATS command gets PHY statistics. Use the phydev pointer
from the ethnl request to allow query phy stats from each PHY on the
link.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
net/ethtool/strset.c | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/net/ethtool/strset.c b/net/ethtool/strset.c
...
quoted hunk ↗ jump to hunk
@@ -279,6 +280,8 @@ static int strset_prepare_data(const struct ethnl_req_info *req_base,
const struct strset_req_info *req_info = STRSET_REQINFO(req_base);
struct strset_reply_data *data = STRSET_REPDATA(reply_base);
struct net_device *dev = reply_base->dev;
+ struct nlattr **tb = info->attrs;
Hi Maxime,
Elsewhere in this function it is assumed that info may be NULL.
But here it is dereferenced unconditionally.
Flagged by Smatch.
+ struct phy_device *phydev;
unsigned int i;
int ret;
...