Thread (63 messages) 63 messages, 9 authors, 2024-07-06

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

From: Kees Cook <kees@kernel.org>
Date: 2024-07-01 15:39:07
Also in: linux-arm-kernel, linux-hardening, linux-rtc, lkml, virtualization

On Mon, Jul 01, 2024 at 09:02:38AM +0100, David Woodhouse wrote:
On Sun, 2024-06-30 at 14:28 +0100, Simon Horman wrote:
quoted
W=1 allmodconfig builds with gcc-13 flag the following.
Reading the documentation of strncpy() in fortify-string.h,
I wonder if strscpy() would be more appropriate in this case.
It's never going to matter in practice, as the buffer is 32 bytes, so
"vmclock%d" would never get to the end even if was a 64-bit integer.

But as a matter of hygiene and best practice, yes strscpy() would be
more appropriate. Fixed in git, thanks.
Thanks! You can even use the 2-argument version. :)

-- 
Kees Cook
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help