From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 30 Jul 2024 18:54:12 -0700

On Mon, 29 Jul 2024 14:07:57 -0700 Kuniyuki Iwashima wrote:

quoted

+	if (WARN_ON((ops->id && !ops->size) || (!ops->id && ops->size)))

I'd write as:

	if (WARN_ON(!!ops->id != !!ops->size))

or

	if (WARN_ON(!!ops->id ^ !!ops->size))

but not 100% sure if it's idiomatic or just my preference..

Actually I wrote the latter first so will use it in v2.
Just not confident about which was easier to read.

Thanks!