Re: [PATCH net-next] ethtool: move firmware flashing flag to struct ethtool_netdev_state
From: Michal Kubiak <hidden>
Date: 2024-07-03 14:30:38
From: Michal Kubiak <hidden>
Date: 2024-07-03 14:30:38
On Wed, Jul 03, 2024 at 01:18:49PM +0100, edward.cree@amd.com wrote:
From: Edward Cree <ecree.xilinx@gmail.com>
Commit 31e0aa99dc02 ("ethtool: Veto some operations during firmware flashing process")
added a flag module_fw_flash_in_progress to struct net_device. AsNitpick: unnecessary space
this is ethtool related state, move it to the recently created struct ethtool_netdev_state, accessed via the 'ethtool' member of struct net_device.
Nitpick: wrong indentation in the commit message
Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com> --- Build tested only.
The code changes look OK. Just the commit message formatting needs to be polished a little bit. Reviewed-by: Michal Kubiak <redacted>