Re: [PATCH net-next 1/3] mlxsw: Warn about invalid accesses to array fields

From
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Date
2024-07-02 07:08:32
Reply to
Petr Machata, 2024-07-01
On 7/1/24 18:41, Petr Machata wrote:
A forgotten or buggy variable initialization can cause out-of-bounds access
to a register or other item array field. For an overflow, such access would
mangle adjacent parts of the register payload. For an underflow, due to all
variables being unsigned, the access would likely trample unrelated memory.
Since neither is correct, replace these accesses with accesses at the index
of 0, and warn about the issue.
That is not correct either, but indeed better.
quoted hunk ↗ jump to hunk
Suggested-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
---
  drivers/net/ethernet/mellanox/mlxsw/item.h | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/item.h b/drivers/net/ethernet/mellanox/mlxsw/item.h
index cfafbeb42586..9f7133735760 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/item.h
+++ b/drivers/net/ethernet/mellanox/mlxsw/item.h
@@ -218,6 +218,8 @@ __mlxsw_item_bit_array_offset(const struct mlxsw_item *item,
  	}
  
  	max_index = (item->size.bytes << 3) / item->element_size - 1;
+	if (WARN_ON(index > max_index))
+		index = 0;
you have BUG*() calls just above those lines :(
anyway, WARN_ON_ONCE(), and perhaps you need to print some additional
data to finally fix this?
  	be_index = max_index - index;
  	offset = be_index * item->element_size >> 3;
  	in_byte_index  = index % (BITS_PER_BYTE / item->element_size);
  
Thread (13 messages) 13 messages, 5 authors, last reply 2024-07-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help