Re: [PATCH net 3/3] selftests/bpf: Null checks for link in bpf_tcp_ca
From: Eduard Zingerman <eddyz87@gmail.com>
Date: 2024-06-24 20:08:59
Also in:
bpf, linux-kselftest
On Mon, 2024-06-24 at 21:27 +0800, Geliang Tang wrote: [...]
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c b/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c index bceff5900016..8c0306f344e9 100644 --- a/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c +++ b/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c@@ -411,7 +411,8 @@ static void test_update_ca(void) return; link = bpf_map__attach_struct_ops(skel->maps.ca_update_1); - ASSERT_OK_PTR(link, "attach_struct_ops"); + if (!ASSERT_OK_PTR(link, "attach_struct_ops")) + return;
At this point the 'skel' is initialized and needs a call to tcp_ca_update__destroy(). Please add a label at the end of this function and goto there instead of 'return'. Same problem in the rest of the hunks. [...]