On Thu, 20 Jun 2024 12:20:44 +0200, Paolo Abeni [off-list ref] wrote:

Hi,

On Tue, 2024-06-18 at 15:56 +0800, Xuan Zhuo wrote:

quoted

@@ -1032,6 +1034,53 @@ static void check_sq_full_and_disable(struct virtnet_info *vi,
 	}
 }

+static void sg_fill_dma(struct scatterlist *sg, dma_addr_t addr, u32 len)
+{
+	sg->dma_address = addr;
+	sg->length = len;
+}
+
+static int virtnet_add_recvbuf_xsk(struct virtnet_info *vi, struct receive_queue *rq,
+				   struct xsk_buff_pool *pool, gfp_t gfp)
+{
+	struct xdp_buff **xsk_buffs;
+	dma_addr_t addr;
+	u32 len, i;
+	int err = 0;

Minor nit: the reverse xmas tree order is based on the full line len,
should be:
	int err = 0;
	u32 len, i;

Will fix.

[...]

quoted

@@ -2226,6 +2281,7 @@ static bool try_fill_recv(struct virtnet_info *vi, struct receive_queue *rq,
 		u64_stats_update_end_irqrestore(&rq->stats.syncp, flags);
 	}

+	oom = err == -ENOMEM;
 	return !oom;

Minor nit: 'oom' is used only in the above to lines. You could drop
such variable and just:
	return err != -ENOMEM;

Will fix.

Please _do not_ repost just for the above, but please include such
changes if you should repost for other reasons.

OK.

Also try to include a detailed changelog in each patch after the tag
area and a '---' separator, it will simplify the review process.

Will do.

Thanks.

Thanks,

Paolo