Re: [PATCH V4 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574
From: Konrad Dybcio <hidden>
Date: 2024-06-25 17:03:33
Also in:
linux-arm-kernel, linux-arm-msm, linux-clk, linux-devicetree, lkml
On 25.06.2024 9:05 AM, Devi Priya wrote:
Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based devices. Signed-off-by: Devi Priya <redacted> Tested-by: Alexandru Gagniuc <redacted> ---
[...]
+ struct regmap *regmap; + struct qcom_cc_desc nsscc_ipq9574_desc = nss_cc_ipq9574_desc;
Why?
+ struct clk *nsscc_clk; + struct device_node *np = (&pdev->dev)->of_node; + int ret; + + nsscc_clk = of_clk_get(np, 11); + if (IS_ERR(nsscc_clk)) + return PTR_ERR(nsscc_clk); + + ret = clk_prepare_enable(nsscc_clk);
pm_clk_add()? And definitely drop the 11 literal, nobody could ever guess or maintain magic numbers Konrad