Thread (4 messages) 4 messages, 3 authors, 2024-06-25

Re: [PATCH v2] net: mana: Fix possible double free in error handling path

From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Date: 2024-06-25 09:13:55
Also in: linux-hyperv, lkml

On 6/25/24 10:38, Ma Ke wrote:
quoted hunk ↗ jump to hunk
When auxiliary_device_add() returns error and then calls
auxiliary_device_uninit(), callback function adev_release
calls kfree(madev). We shouldn't call kfree(madev) again
in the error handling path. Set 'madev' to NULL.

Signed-off-by: Ma Ke <redacted>
---
Changes in v2:
- streamlined the patch according suggestions;
- revised the description.
---
  drivers/net/ethernet/microsoft/mana/mana_en.c | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index d087cf954f75..608ad31a9702 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -2798,6 +2798,8 @@ static int add_adev(struct gdma_dev *gd)
  	if (ret)
  		goto init_fail;
  
+	/* madev is owned by the auxiliary device */
+	madev = NULL;
  	ret = auxiliary_device_add(adev);
  	if (ret)
  		goto add_fail;
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help