Re: [PATCH 01/14] wireguard: allowedips: replace call_rcu by kfree_rcu for simple kmem_cache_free callback
From: Julia Lawall <julia.lawall@inria.fr>
Date: 2024-06-09 14:36:18
Also in:
kernel-janitors, lkml
From: Julia Lawall <julia.lawall@inria.fr>
Date: 2024-06-09 14:36:18
Also in:
kernel-janitors, lkml
On Sun, 9 Jun 2024, Jason A. Donenfeld wrote:
Hi Julia & Vlastimil, On Sun, Jun 09, 2024 at 10:27:13AM +0200, Julia Lawall wrote:quoted
Since SLOB was removed, it is not necessary to use call_rcu when the callback only performs kmem_cache_free. Use kfree_rcu() directly.Thanks, I applied this to the wireguard tree, and I'll send this out as a fix for 6.10. Let me know if this is unfavorable to you and if you'd like to take this somewhere yourself, in which case I'll give you my ack.
Please push it onward. julia
Just a question, though, for Vlastimil -- I know that with the SLOB removal, kfree() is now allowed on kmemcache'd objects. Do you plan to do a blanket s/kmem_cache_free/kfree/g at some point, and then remove kmem_cache_free all together? Jason