Re: [net v5 PATCH] net: stmmac: replace priv->speed with the portTransmitRate from the tc-cbs parameters
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2024-06-08 22:58:29
Also in:
linux-arm-kernel, lkml
On Sat, Jun 08, 2024 at 10:35:24PM +0800, Xiaolei Wang wrote:
The current cbs parameter depends on speed after uplinking,
which is not needed and will report a configuration error
if the port is not initially connected. The UAPI exposed by
tc-cbs requires userspace to recalculate the send slope anyway,
because the formula depends on port_transmit_rate (see man tc-cbs),
which is not an invariant from tc's perspective. Therefore, we
use offload->sendslope and offload->idleslope to derive the
original port_transmit_rate from the CBS formula.
Fixes: 1f705bc61aee ("net: stmmac: Add support for CBS QDISC")
Signed-off-by: Xiaolei Wang <redacted>
Reviewed-by: Wojciech Drewek <redacted>
---Reviewed-by: Vladimir Oltean <olteanv@gmail.com>