Re: [PATCH v2 iproute2 0/3] Multiple Spanning Tree (MST) Support

On 26/06/2024 09:47, Hangbin Liu wrote:

On Mon, Jun 24, 2024 at 03:00:32PM +0200, Tobias Waldekranz wrote:

quoted

This series adds support for:

- Enabling MST on a bridge:

      ip link set dev <BR> type bridge mst_enable 1

- (Re)associating VLANs with an MSTI:

      bridge vlan global set dev <BR> vid <X> msti <Y>

- Setting the port state in a given MSTI:

      bridge mst set dev <PORT> msti <Y> state <Z>

- Listing the current port MST states:

      bridge mst show

Tested-by: Hangbin Liu <redacted>

With following steps:
+ /home/iproute2/ip/ip link add br0 type bridge
+ /home/iproute2/ip/ip link set br0 type bridge mst_enabled 1
+ /home/iproute2/ip/ip link add type veth
+ /home/iproute2/ip/ip link set veth0 master br0
+ /home/iproute2/bridge/bridge vlan add dev br0 vid 1-3 self
+ /home/iproute2/bridge/bridge vlan global set dev br0 vid 2 msti 3
+ /home/iproute2/bridge/bridge vlan add dev veth0 vid 1-3
+ /home/iproute2/bridge/bridge mst set dev veth0 msti 3 state 1
+ /home/iproute2/bridge/bridge mst show
port              msti
veth0             0
                    state disabled
                  3
                    state listening


There is one issue I got (should be kernel issue):

+ /home/iproute2/ip/ip link set br0 type bridge mst_enabled 0
Error: MST mode can't be changed while VLANs exist.

  If I want disable mst, I got failed as there is VLAN info, which is expected

+ /home/iproute2/ip/ip link set veth0 nomaster
+ /home/iproute2/ip/ip link set veth0 master br0
+ /home/iproute2/ip/ip link set br0 type bridge mst_enabled 0
Error: MST mode can't be changed while VLANs exist.

  But I got failed again after remove and re-add veth0, is this expected?
  I thought the VLAN info should be cleared after removing.

Probably default vlan 1 got added to the port when it was enslaved.

+ /home/iproute2/ip/ip link set veth0 nomaster
+ /home/iproute2/ip/ip link set br0 type bridge mst_enabled 0

  It works after I remove veth0.