Thread (6 messages) 6 messages, 3 authors, 2024-06-21

Re: [PATCH net-next 2/2] vsock/virtio: avoid enqueue packets when work queue is empty

From: Luigi Leonardi <hidden>
Date: 2024-06-21 09:49:41
Also in: kvm, virtualization

Hi Matias,
quoted
quoted
I think the test can always send packets at a frequency so the worker queue
is always empty. but maybe, this is a corner case and most of the time the
worker queue is not empty in a non-testing environment.
I'm not sure about this, but IMHO this optimization is free, there is no
penalty for using it, in the worst case the system will work as usual.
In any case, I'm more than happy to do some additional testing, do you have
anything in mind?
Sure!, this is very a interesting improvement and I am in favor for
that! I was only thinking out loud ;)
No worries :)
I asked previous questions
because, in my mind, I was thinking that this improvement would trigger
only for the first bunch of packets, i.e., when the worker queue is
empty so its effect would be seen "only at the beginning of the
transmission" until the worker-queue begins to fill. If I understand
correctly, the worker-queue starts to fill just after the virtqueue is
full, am I right?
Correct! Packets are enqueued in the worker-queue only if the virtqueue
is full.

Luigi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help