Re: [PATCH v5 net-next 4/7] net: ethtool: let the core choose RSS context IDs

On Wed, 19 Jun 2024 10:24:35 -0700 Jakub Kicinski wrote:

On Tue, 18 Jun 2024 23:44:24 +0100 edward.cree@amd.com wrote:

quoted

+ * @create_rxfh_context: Create a new RSS context with the specified RX flow
+ *	hash indirection table, hash key, and hash function.
+ *	Parameters which are set to %NULL or zero will be populated to
+ *	appropriate defaults by the driver.  

The defaults will most likely "inherit" whatever is set in context 0.
So the driver _may_ init the values according to its preferences
but they will not be used by the core (specifically not reported to
user space via ethtool netlink)

Does that match your thinking?

I was thinking about the key, hfunc and xfrm. Indirection table
needs to get reported.