On Tue, 18 Jun 2024 18:15:16 -0700, Jakub Kicinski [off-list ref] wrote:

On Tue, 18 Jun 2024 11:09:02 +0800 Heng Qi wrote:

quoted

quoted

(Should we manually do checksum if RXCUSM is disabled?)
  

Currently we do not allow RXCUSM to be disabled.

You don't have to disable checksuming in the device.

Yes, it is up to the device itself to decide whether to validate checksum.
What I mean is that we don't allow users to disable the driver's
NETIF_F_RXCSUM flag.

Just ignore VIRTIO_NET_HDR_F_DATA_VALID if user cleared NETIF_F_RXCSUM.

Right.

Thanks.

I know some paranoid workloads which do actually want the kernel to
calculate the checksum.