Re: [PATCH net-next v4 0/6] add sriov support for wangxun NICs

2024年6月6日 21:52，Jakub Kicinski [off-list ref] 写道：

On Thu, 6 Jun 2024 18:13:07 +0800 mengyuanlou@net-swift.com wrote:

quoted

quoted

You have cut out the ndo_set_vf_* calls but you seem to add no uAPI
access beyond just enabling the PCI SR-IOV capability. What's your plan
of making this actually usable? It's a very strange submission.  

Vf driver(wxvf) will be submitted later, uAPI for virtual network devices will
be added in it.

I mean the configuration API equivalent to the legacy NDOs.

It starts here.
- https://lore.kernel.org/netdev/20240403185300.702a8271@kernel.org/ (local)

+ .ndo_set_vf_spoofchk = wx_ndo_set_vf_spoofchk,
+ .ndo_set_vf_link_state = wx_ndo_set_vf_link_state,
+ .ndo_get_vf_config = wx_ndo_get_vf_config,
+ .ndo_set_vf_vlan = wx_ndo_set_vf_vlan,
+ .ndo_set_vf_mac = wx_ndo_set_vf_mac,

Whether these interfaces are going to be deprecated, and I have no idea
about what new apis can replace the ndo_{set|get}_vf_xxx interfaces.

I have seen recently submitted driver(octeon_ep) which support sriov, do not 
add ndo_{set|get}_vf_xxx interfaces.
- https://lore.kernel.org/netdev/20231215181425.2681426-1-srasheed@marvell.com/ (local)

If I have missed some docs or code?