RE: [Intel-wired-lan] [PATCH iwl-net v3] ice: implement AQ download pkg retry
From: Pucha, HimasekharX Reddy <hidden>
Date: 2024-06-04 09:58:41
Also in:
intel-wired-lan
From: Pucha, HimasekharX Reddy <hidden>
Date: 2024-06-04 09:58:41
Also in:
intel-wired-lan
-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of Wojciech Drewek
Sent: Friday, May 31, 2024 3:02 PM
To: netdev@vger.kernel.org
Cc: Keller, Jacob E <jacob.e.keller@intel.com>; kuba@kernel.org; intel-wired-lan@lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH iwl-net v3] ice: implement AQ download pkg retry
ice_aqc_opc_download_pkg (0x0C40) AQ sporadically returns error due to FW issue. Fix this by retrying five times before moving to Safe Mode.
Fixes: c76488109616 ("ice: Implement Dynamic Device Personalization (DDP) download")
Reviewed-by: Michal Swiatkowski <redacted>
Signed-off-by: Wojciech Drewek <redacted>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
---
v2: remove "failure" from log message
v3: don't sleep in the last iteration of the wait loop
---
drivers/net/ethernet/intel/ice/ice_ddp.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)Tested-by: Pucha Himasekhar Reddy <redacted> (A Contingent worker at Intel)