Thread (33 messages) 33 messages, 4 authors, 2024-05-23

Re: [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API

From: Simon Horman <horms@kernel.org>
Date: 2024-05-23 12:52:43
Also in: dri-devel, linux-input, lkml, virtualization

[ resending as I mangled the previous attempt , sorry ]

+ Joe Perches

On Wed, May 22, 2024 at 04:39:57PM -0700, Alexey Makhalov wrote:
Hi Simon, apologize for long delay

On 5/11/24 8:02 AM, Simon Horman wrote:
quoted
quoted
diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h
...
quoted
+static inline
+unsigned long vmware_hypercall3(unsigned long cmd, unsigned long in1,
+				uint32_t *out1, uint32_t *out2)
nit: u32 is preferred over uint32_t.
      Likewise elsewhere in this patch-set.
Good to know. Can you please shed a light on the reason?
I still see bunch of stdint style uint32_t in arch/x86.
Perhaps there is a document on this that I should know about.
But AFAIK, u32 and so on are Linux kernel types,
while uint32_t are C99-standard types.

Joe, are you able to shed any further light on this?

...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help