Re: [PATCH] vhost/vsock: always initialize seqpacket_allow
From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-05-17 02:37:08
Also in:
kvm, lkml, virtualization
From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-05-17 02:37:08
Also in:
kvm, lkml, virtualization
On Wed, 15 May 2024 11:05:43 -0400 Michael S. Tsirkin wrote:
There are two issues around seqpacket_allow:
1. seqpacket_allow is not initialized when socket is
created. Thus if features are never set, it will be
read uninitialized.
2. if VIRTIO_VSOCK_F_SEQPACKET is set and then cleared,
then seqpacket_allow will not be cleared appropriately
(existing apps I know about don't usually do this but
it's legal and there's no way to be sure no one relies
on this).Acked-by: Jakub Kicinski <kuba@kernel.org> -- pw-bot: nap