Thread (58 messages) 58 messages, 11 authors, 2024-05-09

Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support

From: Christoph Hellwig <hch@infradead.org>
Date: 2024-05-01 07:55:49
Also in: bpf, linux-alpha, linux-arch, linux-doc, linux-kselftest, linux-media, linux-mips, linux-mm, linux-trace-kernel, lkml, sparclinux

On Fri, Apr 26, 2024 at 05:17:52PM -0700, David Wei wrote:
On 2024-04-02 5:20 pm, Mina Almasry wrote:
quoted
@@ -69,20 +106,26 @@ net_iov_binding(const struct net_iov *niov)
  */
 typedef unsigned long __bitwise netmem_ref;
 
+static inline bool netmem_is_net_iov(const netmem_ref netmem)
+{
+#if defined(CONFIG_PAGE_POOL) && defined(CONFIG_DMA_SHARED_BUFFER)
I am guessing you added this to try and speed up the fast path? It's
overly restrictive for us since we do not need dmabuf necessarily. I
spent a bit too much time wondering why things aren't working only to
find this :(
So what else do you need?  I was assured last round that nothing but
dmabuf and potentially the huge page case (that really just is the page
provider) would get added.
---end quoted text---
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help