Re: [PATCH v2] ax25: Fix refcount imbalance on inbound connections

On Tue, May 21, 2024 at 05:21:40PM GMT, Naveen Mamindlapalli wrote:

quoted

socket *newsock,
 	DEFINE_WAIT(wait);
 	struct sock *sk;
 	int err = 0;
+	ax25_cb *ax25;
+	ax25_dev *ax25_dev;

nit: Please follow reverse Christmas tree.

That is a new phrase for me; I had to look it up. Do you mean this:

        DEFINE_WAIT(wait);
        struct sock *sk;
        int err = 0;
+	      ax25_dev *ax25_dev;
+	      ax25_cb *ax25;

Or should I apply this to the entire block of variable declarations,
like this:

        struct sk_buff *skb;
        struct sock *newsk;
+       ax25_dev *ax25_dev;
        DEFINE_WAIT(wait);
        struct sock *sk;
+       ax25_cb *ax25;
        int err = 0;

Thanks,

-- 
Lars Kellogg-Stedman [off-list ref] | larsks @ {irc,twitter,github}
http://blog.oddbit.com/                | N1LKS