Re: [PATCH net-next v2 5/6] bnxt_en: Optimize recovery path ULP locking in the driver

[PATCH net-next v2 0/6] bnxt_en: Updates for net-next · Michael Chan <michael.chan@broadcom.com> · 2024-05-01
[PATCH net-next v2 1/6] bnxt_en: share NQ ring sw_stats memory with subrings · Michael Chan <michael.chan@broadcom.com> · 2024-05-01
Re: [PATCH net-next v2 1/6] bnxt_en: share NQ ring sw_stats memory with subrings · Simon Horman <horms@kernel.org> · 2024-05-02
[PATCH net-next v2 2/6] bnxt_en: Don't support offline self test when RoCE driver is loaded · Michael Chan <michael.chan@broadcom.com> · 2024-05-01
Re: [PATCH net-next v2 2/6] bnxt_en: Don't support offline self test when RoCE driver is loaded · Simon Horman <horms@kernel.org> · 2024-05-02
[PATCH net-next v2 3/6] bnxt_en: Don't call ULP_STOP/ULP_START during L2 reset · Michael Chan <michael.chan@broadcom.com> · 2024-05-01
Re: [PATCH net-next v2 3/6] bnxt_en: Don't call ULP_STOP/ULP_START during L2 reset · Simon Horman <horms@kernel.org> · 2024-05-02
[PATCH net-next v2 4/6] bnxt_en: Add a mutex to synchronize ULP operations · Michael Chan <michael.chan@broadcom.com> · 2024-05-01
Re: [PATCH net-next v2 4/6] bnxt_en: Add a mutex to synchronize ULP operations · Simon Horman <horms@kernel.org> · 2024-05-02
[PATCH net-next v2 5/6] bnxt_en: Optimize recovery path ULP locking in the driver · Michael Chan <michael.chan@broadcom.com> · 2024-05-01
Re: [PATCH net-next v2 5/6] bnxt_en: Optimize recovery path ULP locking in the driver · Simon Horman <horms@kernel.org> · 2024-05-02
Re: [PATCH net-next v2 5/6] bnxt_en: Optimize recovery path ULP locking in the driver · Jakub Kicinski <kuba@kernel.org> · 2024-05-02
[PATCH net-next v2 6/6] bnxt_en: Add VF PCI ID for 5760X (P7) chips · Michael Chan <michael.chan@broadcom.com> · 2024-05-01
Re: [PATCH net-next v2 6/6] bnxt_en: Add VF PCI ID for 5760X (P7) chips · Simon Horman <horms@kernel.org> · 2024-05-02
Re: [PATCH net-next v2 0/6] bnxt_en: Updates for net-next · patchwork-bot+netdevbpf@kernel.org · 2024-05-02

From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-05-02 14:36:29

On Tue, 30 Apr 2024 17:30:55 -0700 Michael Chan wrote:

Rely on the new en_dev_lock mutex instead for ULP_STOP and
ULP_START.  For the most part, we move the ULP_STOP call before
we take the RTNL lock and move the ULP_START after RTNL unlock.
Note that SRIOV re-enablement must be done after ULP_START
or RoCE on the VFs will not resume properly after reset.

The SRIOV locking looks quite questionable, but it seems to be
an existing problem.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help