Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch

On 19.03.2024 22:38, Andrew Lunn wrote:

quoted

I would argue that EEE advertisement on the PHY should be enabled by
default.

That is an open question at the moment. For some use cases, it can add
extra delay and jitter which can cause problems. I've heard people
doing PTP don't like EEE for example.

The current phylib core code leaves the PHY advertisement whatever its
reset default is. So we leave it to the manufacture to decide if it
should be enabled or disabled by default. It is policy, so it should
really be down to user space to configure EEE how it wants it.

That's fine by me. Then my patch series is okay as it is.

Arınç