Thread (16 messages) 16 messages, 3 authors, 2024-04-12

Re: [PATCH net-next v11 4/9] dt-bindings: net: convert hisi-femac.txt to YAML

From: Yang Xiwen <hidden>
Date: 2024-03-12 00:49:37
Also in: linux-devicetree, lkml

On 3/12/2024 12:03 AM, Jakub Kicinski wrote:
On Sat, 9 Mar 2024 20:30:21 +0800 Yang Xiwen wrote:
quoted
quoted
+  clock-names:
+    items:
+      - const: mac
+      - const: macif
+      - const: phy
Still not very correct here. In downstream the core can also have an
external PHY. The internal phy is also optional. So maybe this clock
should be optional.
You are responding to yourself 4 min after posting?
What is the purpose of your comments?

Just to remind others or myself this can be improved. But i think it's 
ready to be applied. There won't be similar design in mainline soon i think.



-- 
Regards,
Yang Xiwen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help