Thread (28 messages) 28 messages, 7 authors, 2024-03-13

Re: [PATCH] net: dsa: mt7530: disable LEDs before reset

flat view

From: Arınç ÜNAL <hidden>
Date: 2024-03-11 21:23:05
Also in: linux-mediatek, lkml

Why was this applied? I already explained it did not achieve anything.

Arınç

On 12.03.2024 00:10, patchwork-bot+netdevbpf@kernel.org wrote:
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Tue,  5 Mar 2024 06:39:51 +0200 you wrote:
quoted
Disable LEDs just before resetting the MT7530 to avoid
situations where the ESW_P4_LED_0 and ESW_P3_LED_0 pin
states may cause an unintended external crystal frequency
to be selected.

The HT_XTAL_FSEL (External Crystal Frequency Selection)
field of HWTRAP (the Hardware Trap register) stores a
2-bit value that represents the state of the ESW_P4_LED_0
and ESW_P4_LED_0 pins (seemingly) sampled just after the
MT7530 has been reset, as:

[...]
Here is the summary with links:
   - net: dsa: mt7530: disable LEDs before reset
     https://git.kernel.org/netdev/net-next/c/2920dd92b980

You are awesome, thank you!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help