RE: [PATCH net 6/8] net: hns3: fix reset timeout under full functions and queues
From: Sunil Kovvuri Goutham <sgoutham@marvell.com>
Date: 2024-03-07 11:24:28
Also in:
lkml
From: Sunil Kovvuri Goutham <sgoutham@marvell.com>
Date: 2024-03-07 11:24:28
Also in:
lkml
-----Original Message----- From: Jijie Shao <shaojijie@huawei.com> Sent: Thursday, March 7, 2024 6:31 AM To: yisen.zhuang@huawei.com; salil.mehta@huawei.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com Cc: shenjian15@huawei.com; wangjie125@huawei.com; liuyonglong@huawei.com; shaojijie@huawei.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [EXTERNAL] [PATCH net 6/8] net: hns3: fix reset timeout under full functions and queues From: Peiyang Wang <redacted> The cmdq reset command times out when all VFs are enabled and the queue is full. The hardware processing time exceeds the timeout set by the driver. In order to avoid the above extreme situations, the driver extends the reset timeout to 1 second.
Reviewed-by: Sunil Goutham <sgoutham@marvell.com> But one observation, loop of udelay(1) for 1sec seems a lot, probably better to use usleep_range().