Re: [PATCH 2/2] virtio-net: reduce the CPU consumption of dim worker
From: Heng Qi <hidden>
Date: 2024-03-25 02:21:31
Also in:
virtualization
From: Heng Qi <hidden>
Date: 2024-03-25 02:21:31
Also in:
virtualization
在 2024/3/22 下午1:19, Jason Wang 写道:
On Thu, Mar 21, 2024 at 7:46 PM Heng Qi [off-list ref] wrote:quoted
Currently, ctrlq processes commands in a synchronous manner, which increases the delay of dim commands when configuring multi-queue VMs, which in turn causes the CPU utilization to increase and interferes with the performance of dim. Therefore we asynchronously process ctlq's dim commands. Signed-off-by: Heng Qi <redacted>I may miss some previous discussions. But at least the changelog needs to explain why you don't use interrupt.
Will add, but reply here first. When upgrading the driver's ctrlq to use interrupt, problems may occur with some existing devices. For example, when existing devices are replaced with new drivers, they may not work. Or, if the guest OS supported by the new device is replaced by an old downstream OS product, it will not be usable. Although, ctrlq has the same capabilities as IOq in the virtio spec, this does have historical baggage. Thanks, Heng
Thanks