Re: [PATCH net 3/3] netfilter: nf_tables: Fix a memory leak in nf_tables_updchain

On Thu, Mar 21, 2024 at 11:52:29AM +0100, Paolo Abeni wrote:

On Thu, 2024-03-21 at 01:06 +0100, Pablo Neira Ayuso wrote:

quoted

From: Quan Tian <redacted>

If nft_netdev_register_hooks() fails, the memory associated with
nft_stats is not freed, causing a memory leak.

This patch fixes it by moving nft_stats_alloc() down after
nft_netdev_register_hooks() succeeds.

Fixes: b9703ed44ffb ("netfilter: nf_tables: support for adding new devices to an existing netdev chain")
Signed-off-by: Quan Tian <redacted>

I'm sorry for nit-picking, but our tag verification scripts are unhappy
WRT this commit, it lacks your SoB. Would you mind sending an updated
PR?

Sure, sorry about this.