Thread (16 messages) 16 messages, 4 authors, 2024-03-08

Re: [PATCH net-next v3 5/6] doc/netlink: Allow empty enum-name in ynl specs

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-03-07 15:21:26

On Thu, 07 Mar 2024 09:08:30 +0000 Donald Hunter wrote:
quoted
On Wed,  6 Mar 2024 23:10:45 +0000 Donald Hunter wrote:  
quoted
Update the ynl schemas to allow the specification of empty enum names
for all enum code generation.  
Does ethtool.yaml work for you without this change? 
It has an empty enum.

IDK how the check the exact schema version, I have:

$ rpm -qa | grep jsonschema
python3-jsonschema-specifications-2023.7.1-1.fc39.noarch
python3-jsonschema-4.19.1-1.fc39.noarch

The patch seems legit, but would be good to note for posterity 
what made this fail out of the sudden.  
As I mentioned in the earlier thread, the schema already allowed empty
enum-name in definitions. The patch adds it to enum-name in
attribute-sets and operations.
Not sure how I missed that, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help