Re: [PATCH net-next 4/6] net: bcmgenet: remove eee_enabled/eee_active in bcmgenet_get_eee()

On 2/2/2024 1:34 AM, Russell King (Oracle) wrote:

bcmgenet_get_eee() sets edata->eee_active and edata->eee_enabled from
its own copy, and then calls phy_ethtool_get_eee() which in turn will
call genphy_c45_ethtool_get_eee().

genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active
with its own interpretation from the PHYs settings and negotiation
result.

Therefore, setting these members in bcmgenet_get_eee() is redundant,
and can be removed. This also makes priv->eee.eee_active unnecessary,
so remove this and use a local variable where appropriate.

Signed-off-by: Russell King (Oracle) <redacted>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>

Is not there an opportunity for no longer overriding eee_enabled as well 
since genphy_c45_ethtool_get_eee() will set that variable too?
-- 
Florian