On Thu, Feb 01, 2024 at 05:16:44AM -0800, Marcelo Ricardo Leitner wrote:
On Mon, Jan 22, 2024 at 02:47:48PM -0500, Jamal Hadi Salim wrote:
quoted
@@ -1439,7 +1439,7 @@ tc_action_load_ops(struct net *net, struct nlattr *nla,
NL_SET_ERR_MSG(extack, "TC action kind must be specified");
return ERR_PTR(err);
}
- if (nla_strscpy(act_name, kind, IFNAMSIZ) < 0) {
+ if (nla_strscpy(act_name, kind, ACTNAMSIZ) < 0) {
NL_SET_ERR_MSG(extack, "TC action name too long");
return ERR_PTR(err);
}
Subsquent lines here are:
} else {
if (strscpy(act_name, "police", IFNAMSIZ) < 0) {
^^^^^^^^
NL_SET_ERR_MSG(extack, "TC action name too long");
I know it won't make a difference in the end but it would be nice to
keep it consistent.
Despite this, please add my tag in the next iteration:
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>