On Mon, Feb 26, 2024 at 8:43 PM Simon Horman [off-list ref] wrote:

On Sat, Feb 24, 2024 at 09:04:11AM +0000, Dmitry Safonov wrote:

[..]

quoted

+     if (req) {
+             if (tcp_rsk_used_ao(req) != !!aoh) {
+                     u8 keyid, rnext, maclen;
+
+                     if (aoh) {
+                             keyid = aoh->keyid;
+                             rnext = aoh->rnext_keyid;
+                             maclen = tcp_ao_hdr_maclen(aoh);
+                     } else {
+                             keyid = rnext = maclen = 0;
+                     }

Hi Dmitry,

it looks like keyid is set but otherwise unused.

Flagged by W=1 builds with gcc-13 and clang-17.

Hi Simon,

Yeah, I think I didn't notice it when I was splitting the WIP patch.
It should be in the very next patch that uses them:
+                       trace_tcp_ao_handshake_failure(sk, skb, keyid,
rnext, maclen);

Thanks for the report, going to fix in v2,
             Dmitry