Re: [PATCH net-next v5 3/8] net: phy: Add helper to set EEE Clock stop enable bit
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2024-02-23 04:48:02
Also in:
lkml
On 2/20/2024 10:21 PM, Oleksij Rempel wrote:
From: Andrew Lunn <andrew@lunn.ch> The MAC driver can request that the PHY stops the clock during EEE LPI. This has normally been does as part of phy_init_eee(), however that function is overly complex and often wrongly used. Add a standalone helper, to aid removing phy_init_eee(). Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> It would be useful to also read whether the PHY is capable of stopping its clock, this has IMHO always been missing. Clause 45 IEEE PCS Status 1 Register (3.1) bit 6 reflects whether the PHY is capable of stopping its clock. -- Florian