On 2/27/24 16:00, Jakub Kicinski wrote:

On Tue, 27 Feb 2024 11:29:02 +0100 Przemek Kitszel wrote:

quoted

quoted

+ * Device drivers are encouraged to reset the per-queue statistics when
+ * number of queues change. This is because the primary use case for
+ * per-queue statistics is currently to detect traffic imbalance.

I get it, but encouraging users to reset those on queue-count-change
seems to cover that case too. I'm fine though :P

What do you mean? Did I encourage the users somewhere?

I mean that instead of 'driver should reset on q num change' we could
have 'user should reset stats if wants them zeroed' :)

but this is not a strong opinion