Re: [PATCH net-next 0/3] net/staging: Don't bother filling in ethtool driver version

From
Jiri Pirko <jiri@resnulli.us>
Date
2024-02-22 13:24:31
Also in
linux-staging
Reply to
John Garry, 2024-02-22
Thu, Feb 22, 2024 at 10:00:39AM CET, john.g.garry@oracle.com wrote:
The drivers included in this series set the ethtool driver version to the
same as the default, UTS_RELEASE, so don't both doing this.

As noted by Masahiro in [0], with CONFIG_MODVERSIONS=y, some drivers could
be built as modules against a different kernel tree with differing
UTS_RELEASE. As such, these changes could lead to a change in behaviour.
However, defaulting to the core kernel UTS_RELEASE would be expected
behaviour.

These patches are for netdev and staging trees, and I hope that the
respective maintainers can pick up the patches separately.

[0] https://lore.kernel.org/all/CAK7LNASfTW+OMk1cJJWb4E6P+=k0FEsm_=6FDfDF_mTrxJCSMQ@mail.gmail.com/ (local)

John Garry (3):
 rocker: Don't bother filling in ethtool driver version
 net: team: Don't bother filling in ethtool driver version
 staging: octeon: Don't bother filling in ethtool driver version

drivers/net/ethernet/rocker/rocker_main.c | 2 --
drivers/net/team/team.c                   | 2 --
drivers/staging/octeon/ethernet-mdio.c    | 2 --
3 files changed, 6 deletions(-)
The set looks fine to me.

Reviewed-by: Jiri Pirko <redacted>
Thread (6 messages) 6 messages, 3 authors, last reply 2024-02-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help