[PATCH net 3/5] netfilter: nft_flow_offload: release dst in case direct xmit path is used

STALE959d

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2024-02-22 00:08:52
Also in: netfilter-devel
Subsystem: netfilter, networking [general], the rest · Maintainers: Pablo Neira Ayuso, Florian Westphal, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

Revision v1 of 205 in this series.

Revisions (205)

2013-04-12 v1
2013-06-17 v1
2013-10-23 v1
2013-11-21 v1
2013-12-07 v1
2014-02-19 v1
2014-04-05 v1
2014-04-14 v1
2014-05-09 v1
2014-06-18 v1
2014-08-11 v1
2014-10-20 v1
2014-10-27 v1
2015-03-22 v1
2015-05-16 v1
2015-05-22 v1
2015-07-08 v1
2015-08-10 v1
2015-09-03 v1
2015-09-18 v1
2015-11-04 v1
2015-11-11 v1
2016-01-20 v1
2016-02-16 v1
2016-03-28 v1
2016-04-13 v1
2016-06-01 v1
2016-06-17 v1
2016-08-10 v1
2016-08-10 v1
2016-08-30 v1
2016-09-13 v1
2016-10-21 v1
2016-11-10 v1
2016-11-30 v1
2017-01-05 v1
2017-01-26 v1
2017-02-23 v1
2017-02-27 v1
2017-03-15 v1
2017-03-29 v1
2017-04-14 v1
2017-05-29 v1
2017-07-18 v1
2017-08-24 v1
2017-12-13 v1
2018-01-05 v1
2018-02-01 v1
2018-02-20 v1
2018-03-12 v1
2018-06-13 v1
2018-06-27 v1
2018-07-09 v1
2018-07-24 v1
2018-09-11 v1
2018-10-02 v1
2018-10-23 v1
2018-11-06 v1
2018-11-28 v1
2018-12-13 v1
2018-12-29 v1
2019-01-14 v1
2019-02-05 v1
2019-03-11 v1
2019-03-21 v1
2019-05-13 v1
2019-06-17 v1
2019-07-19 v1
2019-07-31 v1
2019-08-14 v1
2019-08-19 v1
2019-08-30 v1
2019-09-04 v1
2019-09-25 v1
2019-11-06 v1
2019-12-09 v1
2019-12-26 v1
2020-01-08 v1
2020-01-25 v1
2020-01-31 v1
2020-02-18 v1
2020-02-26 v1
2020-03-06 v1
2020-04-07 v1
2020-05-14 v1
2020-05-25 v1
2020-05-27 v1
2020-06-14 v1
2020-06-25 v1
2020-08-04 v1
2020-08-15 v1
2020-08-24 v1
2020-08-31 v1
2020-10-07 v1
2020-10-13 v1
2020-10-22 v1
2020-10-31 v1
2020-11-21 v1
2020-12-09 v1
2020-12-18 v1
2021-01-03 v1
2021-03-06 v1
2021-03-19 v1
2021-04-12 v1
2021-05-07 v1
2021-06-10 v1
2021-06-22 v1
2021-07-07 v1
2021-07-23 v1
2021-08-06 v1
2021-08-06 v2 [diff vs current]
2021-09-03 v1
2021-09-29 v1
2021-11-18 v1
2021-12-09 v1
2021-12-17 v1
2022-01-06 v1
2022-01-20 v1
2022-01-27 v1
2022-02-04 v1
2022-02-10 v1
2022-02-21 v1
2022-02-22 v2 [diff vs current]
2022-03-01 v1
2022-03-12 v1
2022-03-17 v1
2022-03-28 v1
2022-04-28 v1
2022-05-18 v1
2022-05-27 v1
2022-05-31 v1
2022-06-06 v1
2022-06-21 v1
2022-06-29 v1
2022-07-11 v1
2022-08-09 v1
2022-08-24 v1
2022-11-09 v1
2022-11-22 v1
2022-11-30 v1
2023-01-02 v1
2023-01-11 v1
2023-01-13 v1
2023-03-01 v1
2023-03-07 v1
2023-03-09 v1
2023-04-18 v1
2023-05-03 v1
2023-06-06 v1
2023-06-08 v1
2023-06-27 v1
2023-07-05 v1
2023-08-10 v1
2023-08-30 v1
2023-09-13 v1
2023-11-08 v1
2023-11-15 v1
2023-12-06 v1
2024-01-17 v1
2024-01-18 v2 [diff vs current]
2024-01-24 v1
2024-01-31 v1
2024-02-07 v1
2024-02-08 v2 [diff vs current]
2024-02-14 v1
2024-02-22 v1 current
2024-02-29 v1
2024-03-07 v1
2024-03-21 v2 [diff vs current]
2024-04-04 v1
2024-04-11 v1
2024-04-18 v1
2024-05-22 v1
2024-05-28 v3 [diff vs current]
2024-06-11 v1
2024-06-19 v1
2024-08-14 v1
2024-08-22 v1
2024-09-24 v1
2024-09-26 v2 [diff vs current]
2024-10-02 v1
2024-10-09 v1
2024-10-31 v1
2024-11-14 v1
2024-11-28 v1
2024-11-28 v2 [diff vs current]
2024-12-05 v1
2024-12-11 v1
2025-03-06 v1
2025-04-03 v1
2025-06-05 v1
2025-07-17 v1
2025-08-07 v1
2026-03-25 v2 [diff vs current]
2026-04-01 v1
2026-04-28 v2 [diff vs current]
2026-05-01 v1
2026-05-07 v1
2026-06-10 v1
2026-06-19 v1
2026-06-20 v2 [diff vs current]
2026-06-23 v1
2026-08-21 v1
2026-08-27 v2 [diff vs current]
2026-09-13 v2 [diff vs current]

Direct xmit does not use it since it calls dev_queue_xmit() to send
packets, hence it calls dst_release().

kmemleak reports:

unreferenced object 0xffff88814f440900 (size 184):
  comm "softirq", pid 0, jiffies 4294951896
  hex dump (first 32 bytes):
    00 60 5b 04 81 88 ff ff 00 e6 e8 82 ff ff ff ff  .`[.............
    21 0b 50 82 ff ff ff ff 00 00 00 00 00 00 00 00  !.P.............
  backtrace (crc cb2bf5d6):
    [<000000003ee17107>] kmem_cache_alloc+0x286/0x340
    [<0000000021a5de2c>] dst_alloc+0x43/0xb0
    [<00000000f0671159>] rt_dst_alloc+0x2e/0x190
    [<00000000fe5092c9>] __mkroute_output+0x244/0x980
    [<000000005fb96fb0>] ip_route_output_flow+0xc0/0x160
    [<0000000045367433>] nf_ip_route+0xf/0x30
    [<0000000085da1d8e>] nf_route+0x2d/0x60
    [<00000000d1ecd1cb>] nft_flow_route+0x171/0x6a0 [nft_flow_offload]
    [<00000000d9b2fb60>] nft_flow_offload_eval+0x4e8/0x700 [nft_flow_offload]
    [<000000009f447dbb>] expr_call_ops_eval+0x53/0x330 [nf_tables]
    [<00000000072e1be6>] nft_do_chain+0x17c/0x840 [nf_tables]
    [<00000000d0551029>] nft_do_chain_inet+0xa1/0x210 [nf_tables]
    [<0000000097c9d5c6>] nf_hook_slow+0x5b/0x160
    [<0000000005eccab1>] ip_forward+0x8b6/0x9b0
    [<00000000553a269b>] ip_rcv+0x221/0x230
    [<00000000412872e5>] __netif_receive_skb_one_core+0xfe/0x110

Fixes: fa502c865666 ("netfilter: flowtable: simplify route logic")
Reported-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/nf_flow_table_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netfilter/nf_flow_table_core.c b/net/netfilter/nf_flow_table_core.c
index 7502d6d73a60..a0571339239c 100644
--- a/net/netfilter/nf_flow_table_core.c
+++ b/net/netfilter/nf_flow_table_core.c

@@ -132,6 +132,7 @@ static int flow_offload_fill_route(struct flow_offload *flow,
 		       ETH_ALEN);
 		flow_tuple->out.ifidx = route->tuple[dir].out.ifindex;
 		flow_tuple->out.hw_ifidx = route->tuple[dir].out.hw_ifindex;
+		dst_release(dst);
 		break;
 	case FLOW_OFFLOAD_XMIT_XFRM:
 	case FLOW_OFFLOAD_XMIT_NEIGH:

-- 
2.30.2

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help