SOF_TIMESTAMPING_OPT_ID is unreliable when sendmsg fails
From: Andy Lutomirski <luto@amacapital.net>
Date: 2024-02-08 18:02:31
From: Andy Lutomirski <luto@amacapital.net>
Date: 2024-02-08 18:02:31
I’ve been using OPT_ID-style timestamping for years, but for some reason this issue only bit me last week: if sendmsg() fails on a UDP or ping socket, sk_tskey is poorly. It may or may not get incremented by the failed sendmsg(). I can think of at least three ways to improve this: 1. Make it so that the sequence number is genuinely only incremented on success. This may be tedious to implement and may be nearly impossible if there are multiple concurrent sendmsg() calls on the same socket. 2. Allow the user program to specify an explicit ID. cmsg values are variable length, so for datagram sockets, extending the SO_TIMESTAMPING cmsg with 64 bits of sequence number to be used for the TX timestamp on that particular packet might be a nice solution. 3. Add a getsockopt to read sk_tskey, which user code could use to determine the next sequence number after a failed sendmsg() call. Thanks, Andy