Thread (6 messages) 6 messages, 2 authors, 2024-02-05

RE: [Intel-wired-lan] [PATCH iwl-next v5 3/3] ixgbe: Clarify the values of the returning status

From: Pucha, HimasekharX Reddy <hidden>
Date: 2024-02-05 17:51:51
Also in: intel-wired-lan

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of Jedrzej Jagielski
Sent: Wednesday, January 31, 2024 4:34 PM
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org; Jagielski, Jedrzej <redacted>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Simon Horman <horms@kernel.org>; Dan Carpenter <redacted>
Subject: [Intel-wired-lan] [PATCH iwl-next v5 3/3] ixgbe: Clarify the values of the returning status

Converting s32 functions to regular int in the previous patch of the series
caused triggering smatch warnings about missing error code.

New smatch warnings:
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3130 ixgbe_enter_lplu_t_x550em() warn: missing error code? 'status'

Old smatch warnings:
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2890 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'

Fix it by clearly stating returning error code as 0.

Reported-by: kernel test robot <redacted>
Reported-by: Dan Carpenter <redacted>
Closes: https://lore.kernel.org/r/202401041701.6QKTsZmx-lkp@intel.com/ (local)
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jedrzej Jagielski <redacted>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Tested-by: Pucha Himasekhar Reddy <redacted> (A Contingent worker at Intel)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help